Should I be doing more warm up sets with all my excersizes?

I see other journals with guys doing this..

I'll get video of my dead-lift form soon.. Still no more soreness than usual..

I do my pushups first to get my lower back pump going, which seems to help..

Then I do a couple warm up sets with no weight at all.. Just going through the motions, keeping my chest up, butt out.. My knee and hip lockout progression still feels out of whack.. I'll get a video going here soon..

Weight still isn't "balls out" weight, but I want to get my form down, while not babying myself completely..

If I'm still badly out of form, I'll go back to a lighter weight and keep plugging away at form..

Biggest concern though is the knee problem..

It's not really painful, really.. Just annoying.. Feels like it's swelling a bit.. Like I have a little pocket of air above the patella that's painful (4/10 stabbing pain) whenever my leg is flexed a bit and I put a load on it.. Like when doing squats or going up or down stairs.

I'll try some ice on it today (haven't been, up till now)..