It's different for everyone...one workout might work well with one person and not be so good for another.Right now my upper body split consists of chest and back/biceps one day and then shoulders/triceps the next.

The reason I split my shoulders and chest is I like to do presses for shoulders, but I find by the time I'm done with my chest, my pressing strength is tapped out (shoulder and/or triceps burnt out?).

Now on those occasions where I do chest with shoulders, I'll do upright rows and lateral raises.

But doing the she-bang in one workout isn't bad though. Especially if you're schedule is tight. It would definitely make it easier to do the entire body 2x in one week.